Event-Federation/wordpress-activitypub
Event-Federation/wordpress-activitypub
7
1
Fork 0
Code Issues 5 Pull requests Projects Releases Wiki Activity Actions 1

check if transformer for wp_type exists #8

New issue
Closed
opened 2023-12-08 12:26:40 +01:00 by ruru4143 · 2 comments
ruru4143 commented 2023-12-08 12:26:40 +01:00
Owner
Copy link

Quick summary

If a client request a acitivitystream for an post type with no transformer, it still tries to create an instance for it

Steps to reproduce

  1. create an post with an unsupported post typ
  2. Make an Get request with "Accept": "application/ld+json; profile="https://www.w3.org/ns/activitystreams""
  3. get an 500 Internal Server Error

What you expected to happen

maybe an 404?

What actually happened

A 500 Internal Server error plus an error in the log

Impact

All

Available workarounds?

No but the platform is still usable

Logs or notes

wordpress_1   | [Fri Dec 08 11:17:42.538553 2023] [php:error] [pid 23] [client 172.20.0.1:0] PHP Fatal error:  Uncaught Error: Class name must be a valid object or a string in /var/www/html/wp-content/plugins/activitypub/includes/transformer/class-transformer-factory.php:281
Stack trace:
#0 /var/www/html/wp-content/plugins/activitypub/templates/post-json.php(5): Activitypub\Transformer\Transformer_Factory->transform(Object(WP_Post))
#1 /var/www/html/wp-includes/template-loader.php(106): include('/var/www/html/w...')
#2 /var/www/html/wp-blog-header.php(19): require_once('/var/www/html/w...')
#3 /var/www/html/index.php(17): require('/var/www/html/w...')
#4 {main}
  thrown in /var/www/html/wp-content/plugins/activitypub/includes/transformer/class-transformer-factory.php on line 281
### Quick summary If a client request a acitivitystream for an post type with no transformer, it still tries to create an instance for it ### Steps to reproduce 1. create an post with an unsupported post typ 2. Make an Get request with "Accept": "application/ld+json; profile="https://www.w3.org/ns/activitystreams"" 3. get an 500 Internal Server Error ### What you expected to happen maybe an 404? ### What actually happened A 500 Internal Server error plus an error in the log ### Impact All ### Available workarounds? No but the platform is still usable ### Logs or notes ``` wordpress_1 | [Fri Dec 08 11:17:42.538553 2023] [php:error] [pid 23] [client 172.20.0.1:0] PHP Fatal error: Uncaught Error: Class name must be a valid object or a string in /var/www/html/wp-content/plugins/activitypub/includes/transformer/class-transformer-factory.php:281 Stack trace: #0 /var/www/html/wp-content/plugins/activitypub/templates/post-json.php(5): Activitypub\Transformer\Transformer_Factory->transform(Object(WP_Post)) #1 /var/www/html/wp-includes/template-loader.php(106): include('/var/www/html/w...') #2 /var/www/html/wp-blog-header.php(19): require_once('/var/www/html/w...') #3 /var/www/html/index.php(17): require('/var/www/html/w...') #4 {main} thrown in /var/www/html/wp-content/plugins/activitypub/includes/transformer/class-transformer-factory.php on line 281 ```
ruru4143 commented 2023-12-08 12:52:48 +01:00
Author
Owner
Copy link

Maybe it's a different bug.

Maybe it's a different bug.
ruru4143 commented 2023-12-08 14:04:52 +01:00
Author
Owner
Copy link

fixed by commit 31c09cd329

fixed by commit 31c09cd329ee01896b311ac87a6af05f98a5b820
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
add/extendable-transformers
add/follow-management
add/manually-approve-application-followers
add/transformer-management
dev/extendable-transformers
main
dev_transformer_manager
fix/max-media-dupes-logic
add/activity-handler
master
add/query-follower-list
add/comment-federation
add/profile-update-pings
fix/accept-follow
update/minimum-wp-version
add/migration
add/sanitization
fix/special-chars
add/filter-followers-view
attachment-link-settings
1.1.0
1.0.10
1.0.9
1.0.8
1.0.7
1.0.6
1.0.5
1.0.4
1.0.3
1.0.2
1.0.1
1.0.0
0.17.0
0.16.5
0.16.4
0.16.3
0.16.2
0.16.1
0.16.0
0.15.0
0.14.3
0.14.2
0.14.1
0.14.0
0.13.4
0.13.3
0.13.2
0.13.1
0.13.0
0.12.0
0.11.2
0.11.1
0.11.0
0.10.1
0.10.0
0.9.1
0.9.0
0.8.3
0.8.2
0.8.1
0.8.0
0.7.4
0.7.3
0.7.2
0.7.1
0.7.0
0.6.0
0.5.1
0.5.0
0.4.4
0.4.3
0.4.2
0.4.1
0.4.0
0.3.2
0.3.1
0.3.0
0.2.1
0.2.0
0.1.1
0.1.0
0.0.2
0.0.1
Labels
Clear labels   
Bug

   
Enhancement

   
Mandatory

   
Upstream Issue

   
Upstream Pull Request
No labels
Bug
Enhancement
Mandatory
Upstream Issue
Upstream Pull Request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Event-Federation/wordpress-activitypub#8
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?