Rewrite of json creation #4

New issue

ruru4143 · 2023-11-29T12:13:28+01:00

ruru4143 commented

2023-11-29 12:13:28 +01:00

I'm not satisfied with how jsonld-objects (activities and transformed wp_posts) are created.

I plan to implement a builder pattern, with the transformers as directors.

I'm not satisfied with how jsonld-objects (activities and transformed wp_posts) are created. I plan to implement a [builder pattern](https://refactoring.guru/design-patterns/builder), with the transformers as directors.

ruru4143 added the due date 2023-12-04

2023-11-29 12:13:51 +01:00

ruru4143 commented

2023-11-29 12:14:03 +01:00

due time is for the first prototype

linos changed title from ~~rewrite of json creation~~ to Rewrite of json creation

2023-11-29 20:26:18 +01:00

linos commented

2023-11-29 20:27:14 +01:00

The basic current strucure of the ActivityPub creation is influenced by the ActivityPub library of landrok. Wheres the library uses a builder pattern approach the ActivityPub WordPress plugin currently ommits this logic.

Pixelfed, one other major ActivityPub platform sharing the PHP language uses Fractal to generate the json-ld output. For example: https://github.com/pixelfed/pixelfed/blob/dev/app/Transformer/ActivityPub/Verb/CreateNote.php

TODO: Review what CastoPod does... https://code.castopod.org/adaures/castopod/-/blob/develop/modules/Fediverse/Core/AbstractObject.php

The basic current strucure of the ActivityPub creation is influenced by the [ActivityPub library of **landrok**](https://github.com/landrok/activitypub/blob/master/src/ActivityPhp/Server/Activity/CreateHandler.php). Wheres the library [uses a builder pattern approach](https://github.com/pixelfed/pixelfed/blob/dev/app/Transformer/ActivityPub/Verb/CreateNote.php) the ActivityPub WordPress plugin currently ommits this logic. **Pixelfed**, one other major ActivityPub platform sharing the PHP language uses **Fractal** to generate the json-ld output. For example: https://github.com/pixelfed/pixelfed/blob/dev/app/Transformer/ActivityPub/Verb/CreateNote.php TODO: Review what CastoPod does... https://code.castopod.org/adaures/castopod/-/blob/develop/modules/Fediverse/Core/AbstractObject.php

linos commented

2023-11-30 08:53:45 +01:00

@ruru4143 I used this branch for my current changes as I did not want to spam the upstream github draft pull request too much! https://code.event-federation.eu/Event-Federation/wordpress-activitypub/src/branch/dev/extendable-transformers

👍 1

ruru4143 commented

2023-12-12 08:45:55 +01:00

There is an (unpolished) but nice looking tribe transformer now, can you give me feedback?

linos commented

2023-12-12 08:50:34 +01:00

There is an (unpolished) but nice looking tribe transformer now, can you give me feedback?

I will give it manual test with my local (not ready to share) Mobilizon interoperability setup and have a look at the code later today.

> There is an (unpolished) but nice looking tribe transformer now, can you give me feedback? I will give it manual test with my local (not ready to share) Mobilizon interoperability setup and have a look at the code later today.

linos commented

2024-01-12 17:55:07 +01:00

https://github.com/Automattic/wordpress-activitypub/pull/629 implements a much more straight forward, though less powerful approach. This was chosen together with the upstream developers.

linos closed this issue

2024-01-12 17:55:07 +01:00

Sign in to join this conversation.