Make a generic event Transformer class #11

Closed
opened 2024-03-09 14:02:07 +01:00 by linos · 3 comments
Owner

Many tasks and function are quite similar across all event transformers, unify them, so that writing a new transformer becomes even easier.

Many tasks and function are quite similar across all event transformers, unify them, so that writing a new transformer becomes even easier.
linos added this to the Transformers for the most common event plugins milestone 2024-03-09 14:02:07 +01:00
linos added the
Enhancement
label 2024-03-09 14:02:07 +01:00
linos self-assigned this 2024-03-09 14:02:07 +01:00
linos added this to the 2. Alpha Phase project 2024-03-09 14:02:07 +01:00
Owner

more information about features for a generic transformer in #12
and a bug thats connected to that in #13

more information about features for a generic transformer in #12 and a bug thats connected to that in #13
ruru4143 self-assigned this 2024-04-15 15:04:26 +02:00
Author
Owner

@ruru4143 I saw your draft at (maybe it is best for us to always good to start a draft PR immediately) 66f3d83f57 (diff-f28a69473c981b6684a17ac0f5b4feb99c4ad579)

  1. You cannot use CamelCase for the class name, but must use Camel_Case, so the Autoloader we will use works (I am planning to add the same one as the ActivityPub plugin uses).

  2. Why did you copy all functions that are already available in the parent transformer?

@ruru4143 I saw your draft at (maybe it is best for us to always good to start a draft PR immediately) https://code.event-federation.eu/Event-Federation/wordpress-activitypub-event-extensions/commit/66f3d83f5744b4bb559034219be316a8454f65d4#diff-f28a69473c981b6684a17ac0f5b4feb99c4ad579 1. You cannot use CamelCase for the class name, but must use Camel_Case, so the Autoloader we will use works (I am planning to add the same one as the ActivityPub plugin uses). 2. Why did you copy all functions that are already available in the parent transformer?
Author
Owner
Already completed. https://code.event-federation.eu/Event-Federation/wordpress-activitypub-event-extensions/src/branch/main/includes/activitypub/transformer/class-event.php
linos closed this issue 2024-09-11 13:09:05 +02:00
Sign in to join this conversation.
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Event-Federation/wordpress-activitypub-event-bridge#11
No description provided.