Event-Federation/wordpress-activitypub-event-bridge
Event-Federation/wordpress-activitypub-event-bridge
5
1
Fork 0
Code Issues 22 Pull requests Projects Releases Packages Wiki Activity Actions

Make a generic event Transformer class #11

New issue
Closed
opened 2024-03-09 14:02:07 +01:00 by linos · 3 comments
linos commented 2024-03-09 14:02:07 +01:00
Owner
Copy link

Many tasks and function are quite similar across all event transformers, unify them, so that writing a new transformer becomes even easier.

Many tasks and function are quite similar across all event transformers, unify them, so that writing a new transformer becomes even easier.
linos added this to the Transformers for the most common event plugins milestone 2024-03-09 14:02:07 +01:00
linos added the
Enhancement
 label 2024-03-09 14:02:07 +01:00
linos self-assigned this 2024-03-09 14:02:07 +01:00
linos added this to the 2. Alpha Phase project 2024-03-09 14:02:07 +01:00
ruru4143 commented 2024-04-15 12:58:35 +02:00
Owner
Copy link

more information about features for a generic transformer in #12
and a bug thats connected to that in #13

more information about features for a generic transformer in #12 and a bug thats connected to that in #13
ruru4143 self-assigned this 2024-04-15 15:04:26 +02:00
linos commented 2024-04-19 19:21:39 +02:00
Author
Owner
Copy link

@ruru4143 I saw your draft at (maybe it is best for us to always good to start a draft PR immediately) 66f3d83f57 (diff-f28a69473c981b6684a17ac0f5b4feb99c4ad579)

  1. You cannot use CamelCase for the class name, but must use Camel_Case, so the Autoloader we will use works (I am planning to add the same one as the ActivityPub plugin uses).

  2. Why did you copy all functions that are already available in the parent transformer?

@ruru4143 I saw your draft at (maybe it is best for us to always good to start a draft PR immediately) https://code.event-federation.eu/Event-Federation/wordpress-activitypub-event-extensions/commit/66f3d83f5744b4bb559034219be316a8454f65d4#diff-f28a69473c981b6684a17ac0f5b4feb99c4ad579 1. You cannot use CamelCase for the class name, but must use Camel_Case, so the Autoloader we will use works (I am planning to add the same one as the ActivityPub plugin uses). 2. Why did you copy all functions that are already available in the parent transformer?
linos commented 2024-09-11 13:09:02 +02:00
Author
Owner
Copy link

Already completed.
https://code.event-federation.eu/Event-Federation/wordpress-activitypub-event-extensions/src/branch/main/includes/activitypub/transformer/class-event.php

Already completed. https://code.event-federation.eu/Event-Federation/wordpress-activitypub-event-extensions/src/branch/main/includes/activitypub/transformer/class-event.php
linos closed this issue 2024-09-11 13:09:05 +02:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
fix_duplicated_event_cat
ci_badge
rename_plugin
improve_tribe_transformer
improve_tribe
transformer_refactoring
timezones
cleanup_file_tops
plugin_doc
tribe_improvements
fix_tribe_location
format_summary
ci_multiple_integrations
improve_tests
ci_mobilizon
ci_gancio
cleanup
improve_actions
forgejo_runner
woodpecker
transformer_improvments_2
class_plugin_adapter
setup_wizard
transformer_improvements
setting_mapping
dev
category_mapping
settings
admin_notices
refactoring
generic-event-transformer
gatherpress
documentation
No results found.
Labels
Clear labels   
Community

   
Enhancement

New feature

  
Mandatory

This has to be priorized

  
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
Community
Enhancement
Mandatory
bug
duplicate
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Transformers for the most common event plugins
Projects
Clear projects
No items
No project
2. Alpha Phase
Assignees
Clear assignees
No assignees
linos
ruru4143
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Event-Federation/wordpress-activitypub-event-bridge#11
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?