From 098b1f578b35825e35d3848da7ac0500c816c0da Mon Sep 17 00:00:00 2001
From: ruru4143 <ruru@event-federation.eu>
Date: Thu, 18 Jul 2024 16:23:34 +0200
Subject: [PATCH] settings: moved slug into const var

---
 includes/admin/class-settings-page.php |  1 +
 templates/admin-header.php             | 10 +++++-----
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/includes/admin/class-settings-page.php b/includes/admin/class-settings-page.php
index 27abc1c..9ad568e 100644
--- a/includes/admin/class-settings-page.php
+++ b/includes/admin/class-settings-page.php
@@ -36,6 +36,7 @@ class Settings_Page {
 	 */
 
 	const static = 'Activitypub_Event_Extensions\Admin\Settings_Page';
+	const settings_slug = 'activitypub-events';
 
 	/**
 	 * Warning if the plugin is Active and the ActivityPub plugin is not.
diff --git a/templates/admin-header.php b/templates/admin-header.php
index 53cb250..a201095 100644
--- a/templates/admin-header.php
+++ b/templates/admin-header.php
@@ -3,14 +3,14 @@ currently reusing activitypub classes which is kinda nice, because it has a cons
 -->
 <div class="activitypub-settings-header">
 	<div class="activitypub-settings-title-section">
-		<h1><?php \esc_html_e( 'Activitypub Events Plugin', 'activitypub-events' ); ?></h1>
+		<h1><?php \esc_html_e( 'Activitypub Events Plugin', $args['slug'] ); ?></h1>
 	</div>
 
-	<nav class="activitypub-settings-tabs-wrapper" aria-label="<?php \esc_attr_e( 'Secondary menu', 'activitypub-events' ); ?>">
+	<nav class="activitypub-settings-tabs-wrapper" aria-label="<?php \esc_attr_e( 'Secondary menu', $args['slug'] ); ?>">
         <!-- todo loop through settings pages of Extractors -->
-		<?php foreach ( $args as $slug => $plugin ) { ?>
-        <a href="<?php echo \esc_url_raw( admin_url( 'options-general.php?page=activitypub-events&tab=' . $slug ) ); ?>" class="activitypub-settings-tab <?php echo \esc_attr( $plugin['active'] ? 'active' : '' ); ?>">
-			<?php \esc_html_e( $plugin['name'], 'activitypub-events' ); ?> <!-- Todo better name handling -->
+		<?php foreach ( $args['options'] as $tabslug => $plugin ) { ?>
+        <a href="<?php echo \esc_url_raw( admin_url( 'options-general.php?page='. $args['slug'] .'&tab=' . $tabslug ) ); ?>" class="activitypub-settings-tab <?php echo \esc_attr( $plugin['active'] ? 'active' : '' ); ?>">
+			<?php \esc_html_e( $plugin['name'], $args['slug'] ); ?> <!-- Todo better name handling -->
         </a>
 		<?php } ?>